Feature/savedprops #230
Feature/savedprops #230
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
| } | ||
| const { contactKey } = user; | ||
|
|
||
| getSavedProperties(contactKey).then((results) => { |
There was a problem hiding this comment.
I'm not sure this is going to work. Line 37 is a promise, so this will always have no results when it executes. If needed, this should be chained with the promise returned there.
There was a problem hiding this comment.
@bstopp I see your point. It is somehow working without chaining. Have not moved the code inside property search promise.
| @@ -445,6 +447,59 @@ main .section.banner .default-content-wrapper { | |||
| text-transform: uppercase; | |||
| } | |||
|
|
|||
| .btn { | |||
There was a problem hiding this comment.
for this:
Felt these could be candidates for global primary and secondary buttons...as I didn't see such styling already implemented.
There was a problem hiding this comment.
There is a primary button global definition, it has a specific dom structure p.button-container > a.
There isn't a secondary one, but that can be achieved with a specific dom structure as well p.button-container > em > a
This will add button secondary classes to the anchor, we would just need to add the CSS to create the ux of the button on the right.
There was a problem hiding this comment.
I haven't made this modal authorable. So, have hard-coded btn-primary and btn-secondary and defined the custom styles for them in styles.css.
There was a problem hiding this comment.
Right, but even though this isn't authorable doesn't mean we can't still generate the same markup as the authored styles, so that we use the same, existing CSS
…to feature/savedprops
Below features are implemented:
Fix #153
Test URLs:
https://feature-savedprops--hsf-commonmoves--hlxsites.hlx.page/account/saved-properties